Re: [PATCH] Fail properly when cloning from invalid HTTP URL
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:07
pasky@suse.cz writes:
quoted hunk
diff --git a/transport.c b/transport.c index 6eb65b8..b88b89b 100644 --- a/transport.c +++ b/transport.c@@ -464,16 +464,15 @@ static struct ref *get_refs_via_curl(struct transport *transport) if (results.curl_result != CURLE_OK) { strbuf_release(&buffer); if (missing_target(&results)) { + die("%s not found: did you run git update-server-info on the server?", refs_url); return NULL;
Hmm, I do not see a deletion of a line here... Everybody else in the get_refs_via_ family just die()s, and the caller of them do not notice nor treat NULL as anything special; I think your patch is a sensible thing to do.