Thread (4 messages) flat view 4 messages, 2 authors, 2016-06-15

Re: [PATCH] perl/Makefile: handle paths with spaces in the NO_PERL_MAKEMAKER section

From: Brandon Casey <hidden>
Date: 2016-06-15 22:45:07

Possibly related (same subject, not in this thread)

Junio C Hamano wrote:
Brandon Casey [off-list ref] writes:
quoted
There are problems here with spaces, single quotes, and double quotes.
I'll follow up in another email.
I guess we've opened up a large can of worms.  Let's have the minimum fix
that says "We do support whitespace in these paths but no other funnies"
and leave the more intrusive one for post 1.6.0, for now.
I think those two patches I just sent are enough.

You can apply the double-quote escaping patch I sent earlier if you want
(the one that escapes double quotes in the macros compiled in c programs).
But we'd have a problem installing the perl scripts using MakeMaker, and
we'd have a problem _running_ the perl scripts since the single double
quote causes a syntax error in the perl script. Let's wait till someone
wants to have " in their path shows up (and let them figure out how to
fix it).

-brandon
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help