Re: [PATCH] correct access right for git-svn-dcommit test
From: Eric Wong <hidden>
Date: 2016-06-15 22:45:06
Dmitry Potapov [off-list ref] wrote:
The tests requires anonymous write access. Therefore, "anon-access = write" is added to conf/svnserve.conf. But because it was added to the end of the file, it is impossible to guarantee in what section it will be located. It turned out that on SVN 1.5, it was placed in the wrong section and as result the test failed. Signed-off-by: Dmitry Potapov <redacted>
Brad and Dmitry: Thank you both very much. Acked-by: Eric Wong <redacted>
quoted hunk ↗ jump to hunk
--- t/t9113-git-svn-dcommit-new-file.sh | 1 + 1 files changed, 1 insertions(+), 0 deletions(-)diff --git a/t/t9113-git-svn-dcommit-new-file.sh b/t/t9113-git-svn-dcommit-new-file.sh index 8da8ce5..ae78e33 100755 --- a/t/t9113-git-svn-dcommit-new-file.sh +++ b/t/t9113-git-svn-dcommit-new-file.sh@@ -28,6 +28,7 @@ start_svnserve () { test_expect_success 'start tracking an empty repo' ' svn mkdir -m "empty dir" "$svnrepo"/empty-dir && + echo "[general]" > "$rawsvnrepo"/conf/svnserve.conf && echo anon-access = write >> "$rawsvnrepo"/conf/svnserve.conf && start_svnserve && git svn init svn://127.0.0.1:$SVNSERVE_PORT &&-- 1.6.0.rc1.74.g1e94