Thread (9 messages) flat view 9 messages, 5 authors, 2016-06-15

Re: Not going beyond symbolic links

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:06

Linus Torvalds [off-list ref] writes:
On Mon, 4 Aug 2008, Junio C Hamano wrote:
quoted
I started to revisit this issue and patched "git update-index --add"
and "git add" so far.  Patches follow.
Patches look good to me, but did you check the performance impact?

The rewritten 'has_symlink_leading_path()' should do ok, but it migth 
still be a huge performance downside to check all the paths for things 
like "git add -u".
Not yet.

I think this is a necessary "correctness" thing to do regardless of the
performance impact, and adding the logic to stop at submodule boundary
(aka gitlinks) should come before optimization.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help