Re: [PATCH] 64bit issue in test-parse-options.c

On Wed, Jul 30, 2008 at 04:05:23PM +0200, Pierre Habouzit wrote:

On Wed, Jul 30, 2008 at 12:44:52PM +0000, H.Merijn Brand wrote:

quoted

On Wed, 30 Jul 2008 14:37:13 +0200, Pierre Habouzit
[off-list ref] wrote:

quoted

  long is wrong in the first place, parse-opt only uses ints.

If I change it to int, the date parsing goes bogus.

That is because OPT_DATE indeed expect a long (why not a time_t I don't
know btw... but time_t is a long on linux so it doesn't change things a
lot).

Still, I think converting to time_t for timestamps would be a good
cleanup; I have added it to http://git.or.cz/gitwiki/Janitor.

				Petr "Pasky" Baudis