Re: git blame not respecting --find-copies-harder ?

On Wed, Jul 30, 2008 at 05:43:52PM +0200, Sverre Rabbelier wrote:

On Wed, Jul 30, 2008 at 17:01, Björn Steinbrink [off-list ref] wrote:

quoted

git blame doesn't know --find-copies-harder, it's -C -C for blame.

Shouldn't it have died with "don't know option --find-copies-harder" then?

Unfortunately, it _does_ know --find-copies-harder, because unknown
options get sent to the revision option parser, which chains to the diff
option parser. So it recognizes --find-copies-harder, but just sets a
flag that doesn't do what we expect.

I'm not sure if there is a simple fix. Does blame actually need the diff
option parsing? If not, then we might be able to pass a flag to
parse_revision_opt that says "don't do diff options, too".

-Peff