Re: [PATCH] format-patch: Produce better output with --inline or --attach

Johannes Schindelin [off-list ref] writes:

quoted

The second change is to always write the line termination character 
(default: newline) even when using --inline or --attach. This is simply 
to improve the aesthetics of the resulting message. When using --inline 
an email client should render the resulting message identically to the 
non-inline version. And when using --attach this adds a blank line 
preceding the attachment in the email, which is visually attractive.

It appears that your patch has one uncontroversial and one controversial 
part, then.

Could you elaborate what's controversial about this?