Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v2] Support copy and rename detection in fast-export.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:05

"Alexander Gavrilov" [off-list ref] writes:
quoted
If you see a copied or renamed entry, you emit "this old path to that old
path" first, and then say that same path got modified.  It appears from my
quick glance of fast-import that touching the same path more than once in
a same commit like this sequence does would work fine (it will involve two
calls to tree_content_set() for the same path but that is not something it
has to forbid, and the function doesn't).
I'm sorry, but I don't quite understand what are you suggesting by
this paragraph.
Sorry for the unmarked remark --- this was not a question, suggestion nor
complaint, but just a plain observation.  I should have ended the
paragraph with "--- I think it's all good." to avoid confusion.
quoted
quoted
+export GIT_AUTHOR_NAME='A U Thor'
+export GIT_COMMITTER_NAME='C O Mitter'
+
+test_expect_success 'setup copies' '
+
+     git config --unset i18n.commitencoding &&
These are somewhat unusual.  Was there any reason for these exports and
config?
t9301-fast-export.sh earlier changes these parameters to test
automatic conversion to utf8.
Yeah, I noticed that while looking at wider context, after I sent the
message you are responding to.

Anyway, thanks for the patch.  Applied and pushed out.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help