Re: [PATCH v2] Advertise the ability to abort a commit

Junio C Hamano wrote:

Anders Melchiorsen [off-list ref] writes:

quoted

-		die("no commit message?  aborting commit.");
+		die("no commit message.  aborting commit.");

[...]

If the change _were_ to reword the message to more neutral sounding
"aborting commit due to missing log message.", and change die() to a
normal exit, that would be making this not an error.  As I already said, I
am mildly negative, but at least such a change would be internally
consistent.

I sense that the change from question mark to full stop might be showing
the desire to go in that direction, but in that case your change from the
question mark to full stop does not go far enough.

I took the question mark to mean that Git was confused about an empty
message. That does not seem right when Git itself proposes it.

I would be happy to also change it to a normal exit. However, since you do
not like the change, let us just forget about that hunk.


Cheers,
Anders.