Thread (9 messages) flat view 9 messages, 4 authors, 2016-06-15

Re: [Fundamental problem with relative system paths] [PATCH 2/2] run-command (Windows): Run dashless "git <cmd>"

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:45:03

Hi,

On Mon, 28 Jul 2008, Steffen Prohaska wrote:
This might solve a fundamental problem we have with the computation of 
system directories based on relative paths in combination with the new 
gitexecpath 'libexec/git-core'. The problem is that the program 'git' is 
hardlinked to directories with different depth.  It is either used as 
'bin/git' (1 directory) or as 'libexec/git-core/git-*' (2 directories).  
Thus, using the same relative path in system_path() yields different 
results when starting from the two locations.  I recognized the problem 
because /etc/gitconfig is no longer be read.
I seem to recall that I already suggested stripping 
"/libexec/git-core/<name>" if it is found, and fall back to 
stripping one directory level (catching "/bin/<name>").

IMHO system_path() should really be that intelligent.

(Of course, the way it is set up now, the _caller_ of git_set_argv0_path() 
has to do the intelligent thing...)

Ciao,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help