Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 3/6] builtin-help: make it possible to exclude some commands in list_commands()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:03

Junio C Hamano [off-list ref] writes:
Johannes Schindelin [off-list ref] writes:
quoted
quoted
quoted
+struct cmdnames {
+	int alloc;
+	int cnt;
+	struct cmdname {
+		size_t len;
+		char name[1];
+	} **names;
+};
I thought we do this kind of thing using FLEX_ARRAY macro.  Is there any
reason its use is not appropriate here?
I think that came up in the previous review round: the "name" member _is_ 
NUL-terminated, but could have a ".exe" suffix.  The "len" member has the 
length excluding ".exe".
Sorry, but I do understand what you are trying to explain.
Yuck, stupid typo; s/do/do not/.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help