Thread (3 messages) flat view 3 messages, 2 authors, 2016-06-15

Re: [PATCH 2/7] builtin-help: change the current directory back in list_commands_in_dir()

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:03

Possibly related (same subject, not in this thread)

Miklos Vajna [off-list ref] writes:
That function used to do a chdir() without switching back to the
original directory. That was not a problem till this function was used
only inside builtin-help, but once other builtins use it as well, this
is a problem, for example when the object database path is relative.
Why does it even need to chdir() around to begin with?  Doesn't opendir()
work just fine with relative path as an input?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help