Thread (54 messages) flat view 54 messages, 9 authors, 2016-06-15

Re: [PATCH] Respect crlf attribute even if core.autocrlf has not been set

From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:45:00

Hi,

On Thu, 24 Jul 2008, Dmitry Potapov wrote:
If you do not have CRLF then there will be no conversion, so you pay 
only the price of check. The relative cost of that check obviously 
depends on what other operations are. I believe that the worst case for 
this check will be when there is no other operations, just re-reading 
files, so I did:

# touch all files to force git re-read them...
git ls-files | xargs touch
time git status

Here is the average based on 3 attempts:
0.232s with autocrlf=false
0.265s with autocrlf=input (14% increase)
And you tested... on git.git?  One of the smallest serious Git users?

If you want to come close to the hard cases (that you would punish with 
setting autocrlf = input, not yourself of course), test _at least_ the 
Linux kernel.

To come closer you should test on OpenOffice.org or KDE.

Hth,
Dscho
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help