Re: [PATCH v2] t6030 (bisect): work around Mac OS X "ls"

On Thu, Jul 24, 2008 at 02:43:51AM -0500, Jonathan Nieder wrote:

t6030-bisect-porcelain.sh relies on "ls" exiting with nonzero
status when asked to list nonexistent files.  Unfortunately,
/bin/ls on Mac OS X 10.3 exits with exit code 0.  So look at
its output instead.

Signed-off-by: Jonathan Nieder <redacted>
---

Mike Hommey wrote:

quoted

On Thu, Jul 24, 2008 at 07:57:26AM +0200, Christian Couder wrote:

quoted

Le jeudi 24 juillet 2008, Jonathan Nieder a �crit :

quoted

-	test_must_fail ls .git/BISECT_* &&
+	echo .git/BISECT_* | test_must_fail grep BISECT_[^*] &&

Perhaps the following is simpler:

+	test -z "$(ls .git/BISECT_*)" &&

That is still a useless use of ls ;)

It is much better than what I wrote, at least.

But could also be written with echo instead of ls.

Mike