[PATCH] git-gui: Look for gitk in $PATH, not $LIBEXEC/git-core
From: Abhijit Menon-Sen <hidden>
Date: 2016-06-15 22:45:00
Subsystem:
the rest · Maintainer:
Linus Torvalds
Signed-off-by: Abhijit Menon-Sen <redacted> --- At 2008-07-24 09:01:48 -0400, john.murphy@bankofamerica.com wrote:
I presume this was just an oversight when git- commands were removed from the bin directory.
Looks like it. The following patch fixes it for me. Does it work for you on Windows? -- ams git-gui/git-gui.sh | 6 +++--- 1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/git-gui/git-gui.sh b/git-gui/git-gui.sh
index 940677c..a70fa67 100755
--- a/git-gui/git-gui.sh
+++ b/git-gui/git-gui.sh@@ -1670,10 +1670,10 @@ proc do_gitk {revs} { # -- Always start gitk through whatever we were loaded with. This # lets us bypass using shell process on Windows systems. # - set exe [file join [file dirname $::_git] gitk] + set exe [_which gitk] set cmd [list [info nameofexecutable] $exe] - if {! [file exists $exe]} { - error_popup [mc "Unable to start gitk:\n\n%s does not exist" $exe] + if {$exe eq {}} { + error_popup [mc "Couldn't find gitk in PATH"] } else { global env
--
1.5.6.GIT