Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] Fix git-svnimport against libsvn_ra.

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:45:00

Thanks.

But the one line description is not descriptive enough, don't you think?

Imagine this line (and nothing else from what you wrote in the body text)
appearing among 100 other commits.  Can you tell what this commit is about
3 months from now on?

Perhaps:

    svnimport: newer libsvn wants us to ask for the root with "", not "/"
In r27729, libsvn introduced an assert which explicitly
forbids searching the tree at "/". Luckily enough, it
still accepts an empty string "" as the starting point.
I think you implied by saying "still", asking with an empty string had the
same effect as asking for the root "/" in earlier versions of SVN, and the
patch will not break people with older libsvn.  Is that correct?
http://svn.collab.net/viewvc/svn/trunk/subversion/libsvn_ra/ra_loader.c?r1=27653&r2=27729
---
Sign-off, please?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help