Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15

Re: [JGIT PATCH 17/28] Support automatic command line parsing for TextBuiltin subclasses

From: Shawn O. Pearce <hidden>
Date: 2016-06-15 22:44:58

Florian KKKberle [off-list ref] wrote:
I had a short look at the files and noticed that the inner "if (help) {"
is unnecessary:

+		if (help) {
+			System.err.print("jgit ");
+			System.err.print(commandName);
+			clp.printSingleLineUsage(System.err);
+			System.err.println();
+
+			if (help) {
Gaaah.  Good catch, thanks.  I copied and pasted that block from the
global option parser to the per-command parser, and then refactored
it a little and missed removing this unnecessary inner if test.
I'll fix with a rebase.

-- 
Shawn.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help