Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH/rfc] git-svn.perl: workaround assertions in svn library 1.5.0

From: Dmitry Potapov <hidden>
Date: 2016-06-15 22:44:57
Subsystem: the rest · Maintainer: Linus Torvalds

On Thu, Jul 17, 2008 at 6:08 PM, Gerrit Pape [off-list ref] wrote:
Hi, while this commit fixed the selftests, it unfortunately is a
regression

 http://thread.gmane.org/gmane.comp.version-control.git/87822/
 http://bugs.debian.org/490400
This particular breakage is easy to fix:
diff --git a/git-svn.perl b/git-svn.perl
index 3750e47..a5a5b1b 100755
--- a/git-svn.perl
+++ b/git-svn.perl
@@ -1226,7 +1226,7 @@ sub linearize_history {

 sub find_file_type_and_diff_status {
        my ($path) = @_;
-       return ('dir', '') if $path eq '.';
+       return ('dir', '') if $path eq '';

        my $diff_output =
            command_oneline(qw(diff --cached --name-status --), $path) || "";
but it could be some other places in git-svn that may need correction too.
I'm still not sure whether this is a git-svn problem, or actually a
problem in subversion 1.5.0
Accordingly to SVN developers you do not use SVN API correctly,
therefore you got assert. So, the problem in git-svn.
http://svn.haxx.se/dev/archive-2008-01/0425.shtml

Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help