Re: [PATCH 2/4] git-imap-send: Add support for SSL.

On Wed, Jul 09, 2008 at 10:24:27PM +0100, Rob Shearman wrote:

quoted

quoted

 [imap]
+    sslverify = false

[...]

quoted

+     else if (!strcmp( "ssl_verify", key ))

The example and the code disagree on the name of the
sslverify/ssl_verify option.

I wouldn't exactly call it "disagree". The config variable is limited
by not allowing underscores, whereas the C language does allow them.

I think his point is that the example says "sslverify" but the code is
looking for the config variable "ssl_verify". So that config won't work.

However as you mention, underscore isn't allowed, so your strcmp line is
totally bogus anyway, but you silently fix it in your 3/4 "style" fix.

-Peff