Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] bash: offer only paths after '--'

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:54

"Shawn O. Pearce" [off-list ref] writes:
Junio C Hamano [off-list ref] wrote:
quoted
SZEDER Gábor [off-list ref] writes:
quoted
Hope that I got the commit message right (;
It was very readable.  Thanks.
Acked-by: Shawn O. Pearce <redacted>
quoted
quoted
+__git_has_doubledash ()
+{
+	local c=1
+	while [ $c -lt $COMP_CWORD ]; do
+		if [ "--" = "${COMP_WORDS[c]}" ]; then
+			return 0
+		fi
+		c=$((++c))
This assignment is somewhat curious, although it should work as expected
either way ;-)
I agree, its damned odd.  But we already do this in the same
sort of loop inside of _git_branch() (see around line 541 in
next).  This new patch is only sticking with our current set
of conventions in the script, so I say its fine.
Chuckling...  Thanks for sanity checking and an Ack.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help