Re: [PATCH] run_command(): respect GIT_TRACE
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:54
Johannes Schindelin [off-list ref] writes:
When GIT_TRACE is set, the user is most likely wanting to see an external command that is about to be executed.
I haven't checked to see if none of the callers of start_command() assumes the current behaviour and is printing this information itself instead, but other than that, your justification feels very sensible. Thanks.
quoted hunk
Signed-off-by: Johannes Schindelin <redacted> --- run-command.c | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-)diff --git a/run-command.c b/run-command.c index 2ce8c2b..6e29fdf 100644 --- a/run-command.c +++ b/run-command.c@@ -65,6 +65,8 @@ int start_command(struct child_process *cmd) cmd->err = fderr[0]; } + trace_argv_printf(cmd->argv, "trace: run_command:"); + #ifndef __MINGW32__ cmd->pid = fork(); if (!cmd->pid) {-- 1.5.6.2.402.g95b5ab.dirty