Thread (2 messages) flat view 2 messages, 2 authors, 2016-06-15
  • (off-list ancestor, not in this archive)
  • Re: [PATCH v5] · Junio C Hamano <hidden> · 2016-06-15
  • Re: [PATCH v5] · Adam Brewster <hidden> · 2016-06-15

Re: [PATCH v5]

From: Adam Brewster <hidden>
Date: 2016-06-15 22:44:53

Possibly related (same subject, not in this thread)

Yeah, it is simply a bad taste to use helper in builtin-A from builtin-B.
More library-ish files such as revision.c are better home for utility
functions to be shared between builtins and commands.

Here is what I queued.
Thank you.
By the way did you compile test your fix before sending?
I ran make and test, but I didn't notice the warnings that prompted
the question.  I also forgot to re-check it after re-working the
commits to put everything in order.
-- >8 --
Thank you again for your help and patience in dealing with my multiple
failed attempts to get this right.

Adam
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help