Re: [PATCH/RFC] Fix some warnings (on cygwin) to allow -Werror

On Jul 3, 2008, at 5:52 PM, Ramsay Jones wrote:

Signed-off-by: Ramsay Jones <redacted>
---

Despite the subject line, this should be useful on any system for
which uint32_t is defined to be unsigned long rather than
unsigned int. (and where the return type of htonl() is similarly
defined).

For MINGW, we fixed these warnings in the compat layer, see cd800eecc2:

diff --git a/compat/mingw.h b/compat/mingw.h
index a87cc96..6bc049a 100644
--- a/compat/mingw.h
+++ b/compat/mingw.h

@@ -186,6 +186,10 @@ pid_t mingw_spawnvpe(const char *cmd, const char  

**argv, char **env);
  void mingw_execvp(const char *cmd, char *const *argv);
  #define execvp mingw_execvp

+static inline unsigned int git_ntohl(unsigned int x)
+{ return (unsigned int)ntohl(x); }
+#define ntohl git_ntohl
+
  sig_handler_t mingw_signal(int sig, sig_handler_t handler);
  #define signal mingw_signal

	Steffen