Re: bug found (Re: git-fast-export SIGSEGV on solaris + backtrace)

SungHyun Nam [off-list ref] writes:

And the code says it:
        for (i = 0; i < idnums.size; ++i) {
                deco++;
                if (deco && deco->base && deco->base->type == 1) {

The 'deco' should be post-incremented? or
Checking code should be  (i < idnums.size - 1)?

The variable "deco" is a pointer that walks over a hashtable from its
offset 0 to its end, so it can never be NULL (well, the code increments
before it tests the variable for NULLness, so it is clear that the test is
bogus).

What was I smoking when I applied df6a7ff (builtin-fast-export: Add
importing and exporting of revision marks, 2008-06-11), I have to
wonder...

Thanks for the fix.