Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH] git.el: Don't reset HEAD in git-amend-file.

From: Alexandre Julliard <hidden>
Date: 2016-06-15 22:44:50

Nikolaj Schumacher [off-list ref] writes:
The current implementation of git-amend-file is a little dangerous.
While git --amend is atomic, git-amend-file is not.

If the user calls it, but doesn't go through with the commit (due to
error or choice), git --reset HEAD^ has been called anyway.
That's a feature, even if it's a little dangerous. You have to reset
HEAD to be able to properly do diffs, refreshes, etc.  Maybe there should
be an easier way to redo the commit if you change your mind, but the
command would be much less useful without the reset.

-- 
Alexandre Julliard
julliard@winehq.org
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help