Re: apply --recount, was Re: [PATCH v4] git-add--interactive: manual hunk editing mode

On Mon, Jun 23, 2008 at 10:16:08PM +0100, Johannes Schindelin wrote:

I think it was not a flaw, but something to be worried about: 

http://mid.gmane.org/7v4p87zcv6.fsf@gitster.siamese.dyndns.org

To spare you following that link: Junio wanted to reuse "git apply 
--recount" to apply mboxes, where a separator "^-- $" to the signature is 
quite common, and could be mistaken for a "-" line of a hunk.

Ah, OK. Thanks for the recap, that makes sense to me now.

However, I think that this issue should not concern us _now_.  As long as 
--recount is only to be used in "add -i" and "add -e", I think the patch 
is good as is:

I agree. We can worry about the other when and if somebody decides to
use it that way (but maybe Junio is already planning to do so...).

Thomas, do you want to just re-submit the "--recount" patches when you
re-submit your patch?

-Peff