Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH v3] builtin-fast-export: Add importing and exporting of revision marks

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:43

Pieter de Bie [off-list ref] writes:
This adds the --import-marks and --export-marks to fast-export. These import
and export the marks used to for all revisions exported in a similar fashion
to what fast-import does. The format is the same as fast-import, so you can
create a bidirectional importer / exporter by using the same marks file on
both sides.
Heh, I've long queued a fixed-up version in 'pu' as 4ba0575
(builtin-fast-export: Add importing and exporting of revision marks,
2008-06-05).

I think renaming the "mark_object" to "mark_next_object" makes quite a lot
of sense, and I do not have any preference between mark2deco vs mark_to_ptr 
nor between a macro vs a static inline function for something small like
these.

You still use export_filename and import_filename uninitialized in
cmd_fast_export() and breaks everybody who does not use export-marks
option.  Has this patch (and the previous one I fixed up before queuing it
in 'pu') ever been tested?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help