Thread (11 messages) flat view 11 messages, 2 authors, 2016-06-15

Re: [EGIT PATCHES] Assorted minor fixes

From: Robin Rosenberg <hidden>
Date: 2016-06-15 22:44:43

tisdagen den 10 juni 2008 02.31.44 skrev Shawn O. Pearce:
How did you you send this series?  Its not format-patch output.
The diff-stat is missing from each commit, and there's no ---
to split message from diff.  I didn't bother trying to run them
through git-am yet as I assume I can just fetch from you, I'm
just saying the patches look "odd".
It was git format-patch --binary. Seems that option drops the diffstat
in that case. Yes you can just pull and get the same series. I mostly
sent it as patches for review purposes. It is much easier in e-mail.
Using gtik for reviiew isn't optimal. A nice tool for reviewing and
commenting directly from a repo would be nice.

-- robin
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help