Re: [PATCH] This patch is to allow 12 different OS's to compile and run git.
From: Jeremy Maitin-Shepard <hidden>
Date: 2016-06-15 22:44:42
Possibly related (same subject, not in this thread)
- 2016-06-15 · [PATCH] This patch is to allow 12 different OS's to compile and run git. · Boyd Lynn Gerber <hidden>
- 2016-06-15 · Re: [PATCH] This patch is to allow 12 different OS's to compile and run git. · Thomas Harning <hidden>
- 2016-06-15 · Re: [PATCH] This patch is to allow 12 different OS's to compile and run git. · Daniel Barkalow <hidden>
- 2016-06-15 · Re: [PATCH] This patch is to allow 12 different OS's to compile and run git. · Boyd Lynn Gerber <hidden>
Boyd Lynn Gerber [off-list ref] writes: [snip]
quoted hunk
diff --git a/progress.c b/progress.c index d19f80c..11a0841 100644 --- a/progress.c +++ b/progress.c@@ -241,7 +241,8 @@ void stop_progress_msg(struct progress **p_progress, constchar *msg) *p_progress = NULL; if (progress->last_value != -1) { /* Force the last update */ - char buf[strlen(msg) + 5]; + /* char buf[strlen(msg) + 5]; */ + char *buf = malloc (strlen(msg) + 5 );
This change will result in the allocated memory being leaked, which is probably not correct. Perhaps change it to alloca instead. -- Jeremy Maitin-Shepard