Thread (4 messages) flat view 4 messages, 3 authors, 2016-06-15

Re: [PATCH v2 1/2] Allow git-apply to ignore the hunk headers

From: Paolo Bonzini <hidden>
Date: 2016-06-15 22:44:42

quoted hunk ↗ jump to hunk
@@ -0,0 +0,0 @@
 	default:
-		return -1;
+		return len != 4 && memcmp(line - len, "-- \n", len);
 	}
You're never returning -1 here, right?
However, this will not work if anybody has a signature starting with 
"@@ ", "+", " ", "-" or "diff "...
I think that the main worry is the patches made with git-format-patch, 
and those are not problematic.

Paolo
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help