Re: [JGIT PATCH v3 0/23] Implementation of a file tree iteration using ignore rules.

fredagen den 23 maj 2008 22.34.09 skrev Florian Koeberle:

Hi

This patch set contains a new fnmatch implementation.

Looks ok, with me. Only minor comments in separate mail.

Unsupported are colon expressions like ":alpha:". I didn't expect git-add to support it, but as I just noticed git does.

Maybe we should anticipate it and throw an exception if one tries the pattern and not treat it as [alph:] .

Well we noted they were broken in Git so (separate thread) so we may as well try something sane. 

-- robin