Re: [PATCH] builtin-fast-export: Add importing and exporting of revision marks

Hi,

On Thu, 5 Jun 2008, Pieter de Bie wrote:

On 5 jun 2008, at 02:00, Johannes Schindelin wrote:

quoted

Is "- (uint32_t *)NULL" needed?

I changed the uintmax_t to to a uint32_t. If I remove the "- (uint32_t
*)NULL", it won't return the same marks. The same is done in 
 get_object_mark().

Ah, I missed that again.  I think I had exactly the same issue (of not 
understanding) with another patch for the same area of the code.

Maybe it would be worth having two functions to describe what is done 
there, for documentation purposes?

I will send an updated patch.

Thanks,
Dscho