Thread (9 messages) flat view 9 messages, 4 authors, 2016-06-15

Re: [PATCH] Revert "git.el: Set process-environment instead of invoking env"

From: David Christensen <hidden>
Date: 2016-06-15 22:44:40

This reverts commit dbe48256b41c1e94d81f2458d7e84b1fdcb47026, which
caused mis-encoding of non-ASCII author/committer names when the
git-status mode is used to create commits.

Signed-off-by: Karl Hasselström <redacted>

---

On 2008-05-30 13:27:43 -0700, Junio C Hamano wrote:
quoted
Karl Hasselström [off-list ref] writes:
quoted
How are things going with this fix? Junio, I expect you're waiting
for a properly cleaned-up patch, possibly with acks from relevant
people?
You expected correctly.
In case no one who understands how, why, and whether the fix works
comes forward, here's a revert of the commit that introduced the
problem.
This likely is due to the process-coding-system selected by emacs;  
the correct functioning of this command will rely on both the current  
buffer's coding system and the coding system of the data returned by  
the invocation of git-status.  In order for this to function  
properly, these should match.  Both of these are variables which can  
be customized local to the buffer as part of the routine, so this  
could be fixed if we are able to determine at invocation time what  
coding system the git-status command will return in (presumably some  
form of utf-8, but I believe this is configurable per repo).

I'd be glad to take a more in-depth look at this, but I'm not up on  
the code at this point.

Regards,

David
--
David Christensen
End Point Corporation
david@endpoint.com
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help