Re: [PATCH] perl/Git.pm: add rev_parse method
From: Petr Baudis <hidden>
Date: 2016-06-15 22:44:39
Hi, On Fri, May 30, 2008 at 06:43:05AM +0200, Lea Wiemann wrote:
quoted hunk ↗ jump to hunk
diff --git a/perl/Git.pm b/perl/Git.pm index d05b633..9ef8cb0 100644 --- a/perl/Git.pm +++ b/perl/Git.pm@@ -716,6 +716,28 @@ sub ident_person { return "$ident[0] <$ident[1]>"; } +=item rev_parse ( REVISION_NAME )
I believe it would be more consistent to call it parse_rev() and in fact also less confusing since this is not full-fledged rev-parse frontend (and probably should not be; rev-parse is terribly overloaded with much more stuff).
+
+Look up the specified revision name and return the SHA1 hash, or
+return undef if the lookup failed. See the git-rev-parse command.
+
+=cut
+
+sub rev_parse {
+ # We could allow for a list of revisions here.
+ my ($self, $rev_name) = @_;
+
+ my $hash;
+ try {
+ # The --default option works around rev-parse's lack of
+ # support for getopt style "--" separators (it would fail for
+ # tags named "--foo" without it).
+ $hash = $self->command_oneline("rev-parse", "--verify", "--default",
+ $rev_name);
+ } catch Git::Error::Command with { };I think it is better style to use the regular pattern of checking $E->value() and either return undef right away or pass the exception (e.g. in case rev-parse cannot be executed for some reason).
+ return undef unless defined $hash and $hash =~ /^([0-9a-fA-F]{40})$/;When can this trigger?
+ $hash; +} =item hash_object ( TYPE, FILENAME )
-- Petr "Pasky" Baudis Whatever you can do, or dream you can, begin it. Boldness has genius, power, and magic in it. -- J. W. von Goethe