Re: [PATCH] git-svn fails in prop_walk if $self->{path} is not empty
From: Nikolaus Schulz <hidden>
Date: 2016-06-15 22:44:39
Happy coincidence!
This patch happens to fix my problem posted in "git-svn
{show,create}-ignore chokes upon subdirs" today.
Nikolaus
On Tue, May 27, 2008 at 08:46:55AM +0000, Gerrit Pape wrote:quoted hunk ↗ jump to hunk
From: Christian Engwer <redacted> The problem now is that prop_walk strips trunk from the path and then calls itself recursively. But now trunk is missing in the path and get_dir fails, because it is called for a non existing path. The attached patch fixed the problem, by adding the priviously stipped $self->{path} in the recursive call. git-svn repository for the commands show-ignore and show-external. Patch was submitted through http://bugs.debian.org/477393 Signed-off-by: Gerrit Pape <redacted> --- I'm not that much a git-svn user, and didn't test this thoroughly. I'd be happy if anyone could crossread/test this, and maybe add a Acked-By. Thanks, Gerrit. git-svn.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-)diff --git a/git-svn.perl b/git-svn.perl index 37976f2..72fef16 100755 --- a/git-svn.perl +++ b/git-svn.perl@@ -1918,7 +1918,7 @@ sub prop_walk { foreach (sort keys %$dirent) { next if $dirent->{$_}->{kind} != $SVN::Node::dir; - $self->prop_walk($p . $_, $rev, $sub); + $self->prop_walk($self->{path} . $p . $_, $rev, $sub); } }