Re: [PATCH] clone: make sure we support the transport type

On Tue, 27 May 2008, Mike Hommey wrote:

On Tue, May 27, 2008 at 10:28:43AM -0400, Jeff King wrote:

quoted

If we use an unsupported transport (e.g., http when curl
support is not compiled in), transport_get reports an error
to the user, but we still get a transport object. We need to
manually check and abort the clone process at that point, or
we end up with a segfault.

Shouldn't transport_get return NULL in such a situation, instead ?

Perhaps, but we would still want to account for the possibility of a 
transport that only supports pushing or something like that, and therefore 
is available for the URL but isn't suitable for clone.

	-Daniel
*This .sig left intentionally blank*