Thread (1 message) 1 message, 1 author, 2016-06-15

Re: [PATCH 4/3] bisect: use a detached HEAD to bisect

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:38

Paul Mackerras [off-list ref] writes:
Linus Torvalds writes:
quoted
Of course, _usually_ it's just the top commit, and it's obvious that way 
which one is the checked-out one, but if you do "gitk --all" or just 
generally have multiple branches, right now it's hard to see what commit 
is the checked-out one, regardless of whether it's detached or not.
If it's not detached, the branch name is in bold, but evidently that's
either not intuitive or not sufficiently distinct...
quoted
I think "HEAD" in a green box would solve that too, but on the other hand, 
we have a *lot* of boxes already. For people who mainly just track another 
repo, you already have one box saying "master", and another one saying 
"remotes/origin/master", and adding yet *another* box saying HEAD that 
just points to the same commit will work, but do we really want that?

I actually like the red circle for "Local uncommitted changes". Maybe we 
can use a similar visual clue for "currently checked out". You already 
picked green for the "added to the index" case, so we have the three 
primary RGB colors already used, but we could make it just be a deep 
yellow.

Of course, maybe people hate lots of colos already, and something more 
akin to the text background thing that we use for the selected commit 
would be better.

I dunno. There's so many options.

Here's a "make it yellow" patch.
Thanks.  I have checked in something similar, that also handles the
cases where you update the graph and the head has moved, and when you
do a checkout or reset using the gitk menus.
Thanks.  Will pull, but it will have to miss upcoming 1.5.6-rc0,
unfortunately.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help