Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: [PATCH] Fix t3701 if core.filemode disabled

From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:38

Alex Riesen [off-list ref] writes:
Jeff King, Wed, May 21, 2008 16:36:07 +0200:
quoted
2. It's a little hard to see which tests are affected. I would have done
   something more like:

  if test "$(git config --bool core.filemode)" = true
    test_filemode=
  else
    test_filemode=:
  fi

  $test_filemode test_expect_success ...

  But maybe that is just overengineering.
But a nice one. I like the idea but Junio already did your other
suggestions in master, so I just keep it in mind for the next one
If you like that, I think you would like the way t0050 does even better
;-).  It is Steffen Prohaska's invention, IIRC.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help