Re: [PATCH 2/2] Add support for GIT_CEILING_DIRS

Hi,

On Wed, 14 May 2008, Kevin Ballard wrote:

On May 14, 2008, at 3:23 AM, Johannes Schindelin wrote:

quoted

quoted

@@ -414,6 +415,37 @@ const char *setup_git_directory_gently(int *nongit_ok)

if (!getcwd(cwd, sizeof(cwd)-1))
 die("Unable to read current working directory");

+	// Compute min_offset based on GIT_CEILING_DIRS.

We do not like C99 style comments.  Remember, there are people who compile
Git on something else than the super-latest Linux with cutting-edge GCC.

Out of curiosity, what environment these days doesn't allow C99 comments?

On an SGI/IRIX machine I was working some time ago, GCC was too big for my 
quota.  And the admin was not willing to install it.

But I have to wonder: why argue something as C99 comments, when it is _no 
problem_ whatsoever to replace them with C89-style comments, especially 
given the fact that this makes our source code more consistent and thus 
easier on the eye?

Ciao,
Dscho