Re: [PATCH 2/5] Make mktag a builtin.

Hi,

On Mon, 12 May 2008, Brandon Casey wrote:

Junio C Hamano wrote:

quoted

drafnel@gmail.com writes:

quoted

From: Brandon Casey <redacted>

Signed-off-by: Brandon Casey <redacted>

quoted

@@ -306,6 +305,7 @@ BUILT_INS += git-fsck-objects$X
 BUILT_INS += git-get-tar-commit-id$X
 BUILT_INS += git-init$X
 BUILT_INS += git-merge-subtree$X
+BUILT_INS += git-mktag$X
 BUILT_INS += git-peek-remote$X
 BUILT_INS += git-repo-config$X
 BUILT_INS += git-show$X

@@ -423,6 +423,7 @@ LIB_OBJS += log-tree.o
 LIB_OBJS += mailmap.o
 LIB_OBJS += match-trees.o
 LIB_OBJS += merge-file.o
+LIB_OBJS += mktag.o

This is unusual for a builtin.  Why didn't it migrate to builtin-mktag?

I didn't know how to do it.

I was trying not to do a code move and a code change at the same time.

Why did you not consult Git's own history for guidance?  See e.g.

	$ git log next --diff-filter=A builtin-*.c

Ciao,
Dscho