Re: [PATCH 2/2] builtin-tag.c: use valid_ident for checking tagger field

Junio C Hamano wrote:

drafnel@gmail.com writes:

quoted

From: Brandon Casey <redacted>

Use valid_ident function for validating the tagger field
in generated tags rather than a tag specific version.

Also update tests.

Signed-off-by: Brandon Casey <redacted>
---
 builtin-tag.c    |   39 +++++----------------------------------
 t/t3800-mktag.sh |   14 +++++++-------
 2 files changed, 12 insertions(+), 41 deletions(-)

diff --git a/builtin-tag.c b/builtin-tag.c
index 0f79d47..2dcb795 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c

@@ -339,8 +339,7 @@ static int verify_tag_buffer(const char *buffer, size_t size)
 	int typelen;
 	char type[20];

Funny.

This [2/2] seems to depend on [3/5] that renames verify_tag to verify_tag_buffer().

What is going on?

Yes, sorry. I should have mentioned this.

I implemented this after the other series, but it could just as well be merged into one,
with these two coming before the 5 patch mktag stuff. I can resubmit if you like.

-brandon