Re: [PATCH] Makefile: update the default build options for AIX
From: Johannes Sixt <hidden>
Date: 2016-06-15 22:44:34
Mike Ralphson schrieb:
quoted hunk ↗ jump to hunk
NO_MKDTEMP is required to build, FREAD_READS_DIRECTORIES and the definition of _LARGE_FILES fix test suite failures and INTERNAL_QSORT is required for adequate performance. Tested on AIX v5.3 Maintenance Level 06 Signed-off-by: Mike Ralphson <redacted> --- Makefile | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-)diff --git a/Makefile b/Makefile index 7c70b00..4296656 100644 --- a/Makefile +++ b/Makefile@@ -632,8 +632,12 @@ endif ifeq ($(uname_S),AIX) NO_STRCASESTR=YesPlease NO_MEMMEM = YesPlease + NO_MKDTEMP = YesPlease NO_STRLCPY = YesPlease + FREAD_READS_DIRECTORIES = UnfortunatelyYes + INTERNAL_QSORT = UnfortunatelyYes NEEDS_LIBICONV=YesPlease + BASIC_CFLAGS += -D_LARGE_FILES endif ifeq ($(uname_S),GNU) # GNU/Hurd
I'm trying this patch on AIX 4.3.3 (sigh!) with gcc3. I get this:
git-compat-util.h:209:1: warning: "fopen" redefined
In file included from git-compat-util.h:51,
from builtin.h:4,
from git.c:1:
/usr/local/lib/gcc-lib/powerpc-ibm-aix4.3.2.0/3.2.1/include/stdio.h:110:1:
warning: this is the location of the previous definition
Line 110 in ...include/stdio.h is inside a #ifdef _LARGE_FILES section and
says:
#define fopen fopen64
Did you also get this warning? Is _LARGE_FILES support solved in a
different way on 5.3?
-- Hannes