Thread (3 messages) flat view 3 messages, 3 authors, 2016-06-15

Re: gitk: synchronize highlighting in file view for 'f'&'b' commands

From: Paul Mackerras <hidden>
Date: 2016-06-15 22:44:33

Eric Raible writes:
Previously, 'b', backspace, and delete all did the same thing.
This changes 'b' to perform the inverse of 'f'.  And both of
them now highlight the filename of the currently diff.
OK, but...
+    set file [regsub -- "-* (.*?) -*" [$ctext get $loc "$loc lineend"] "\\1"]
+    set cline [$cflist search -regexp [subst {^$file$}] 0.0]
This seems to be working out the index of the line we want to
highlight in the file list, but both the callers of highlightfile can
supply that info much more easily by incrementing a count as they go
through $difffilestart, as far as I can tell.

Paul.
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help