Re: [PATCH 01/11] Add tests for git cat-file

Eric Wong [off-list ref] writes:

Adam Roben [off-list ref] wrote:

quoted

Signed-off-by: Adam Roben <redacted>
---
 t/t1006-cat-file.sh |  101 +++++++++++++++++++++++++++++++++++++++++++++++++++
 1 files changed, 101 insertions(+), 0 deletions(-)
 create mode 100755 t/t1006-cat-file.sh

diff --git a/t/t1006-cat-file.sh b/t/t1006-cat-file.sh
new file mode 100755
index 0000000..15741d9
--- /dev/null
+++ b/t/t1006-cat-file.sh

@@ -0,0 +1,101 @@
+#!/bin/sh
+
+test_description='git cat-file'
+
+. ./test-lib.sh
+
+function echo_without_newline()

The "function " keyword is a bashism and not needed, this breaks
my test run with dash as /bin/sh (same thing in t1007).

quoted

+{
+    echo "$@\c"

I guess we have different bash versions/options, because this breaks for
me in bash (3.1dfsg-8 from Debian etch).  It would need -e to handle to
handle escape sequence, but that's a bashism, too.

Use printf "$@" here instead.

Looking at the callers, I do not think you want that.  I would suggest
something defensive like:

	printf '%s' "$*"