Re: [PATCH] builtin-apply: Show a more descriptive error on failure when opening a patch
From: Johannes Schindelin <hidden>
Date: 2016-06-15 22:44:29
Possibly related (same subject, not in this thread)
- 2016-06-15 · Re: [PATCH] builtin-apply: Show a more descriptive error on failure when opening a patch · Johannes Schindelin <hidden>
- 2016-06-15 · Re: [PATCH] builtin-apply: Show a more descriptive error on failure when opening a patch · Junio C Hamano <hidden>
- 2016-06-15 · [PATCH] builtin-apply: Show a more descriptive error on failure when opening a patch · Alberto Bertogli <hidden>
Hi, On Mon, 14 Apr 2008, Alberto Bertogli wrote:
+ if (fd < 0) {
+ error("can't open patch '%s': %s", arg,
+ strerror(errno));
+ return 1;
+ }Do you absolutely want to retain the curly braces, and have two statements? I would prefer "return error(...)", and if you absolutely insist on a return 1: "return !!error(...)". Ciao, Dscho