Re: Is my repository broken?

On Tue, 8 Apr 2008, Junio C Hamano wrote:

Julian Phillips [off-list ref] writes:

quoted

On Tue, 8 Apr 2008, Shawn O. Pearce wrote:

quoted

The same holds true for the empty ident.

Ok - but I can't even find a note in the manpage for this one ...

That's not a fair complaint.

I didn't mean it as a complaint, but rather was hoping for a response of 
the form "no, it's not there" or "it's in the ... section" - sorry for not 
being clear.  It caught me out, if that was my own fault then fair enough 
- but if this was because the documentation doesn't make it clear then I 
can submit a documentation patch to try and help others avoid the same 
problem.

I think that the fast-import tool is extremely useful, and generally very 
well documented.  That doesn't mean that the documentation can't be 
improved though.

It is often very hard to document that "we do not do X", because the line
to stop at becomes fuzzier as you try to do more thorough job.  We do not
warn on empty ident, we do not warn on typos in commit log messages, we do
not warn on empty blob, we do not warn on ...  You get the idea.

Git doesn't die when trying to commit typos though ...  I think "creating 
a commit that you could not create using git-commit" is a pretty hard 
line.

I don't think that it is entirely unreasonable to expect that when an 
existing repository is run through a tool like filter-branch that all your 
existing commits are preserved - and that you don't lose large chunks 
because it turns out that they are actually invalid by the rules of 
git-commit.

I accept that you may want fast-import to create things that are 
technically illegal, but at the very least it ought to be possible to find 
out what restrictions are not being enforced.  Otherwise it might be that 
you manage to destroy a previously functioning repository by accident long 
after you thought you had successfully converted your respository.  After 
all, I would have thought that the majority of people using fast-import 
(either directly, or indirectly by using a fast-import based importer) 
would actually intend to use the repository created with the normal git 
tools from then on.

-- 
Julian

  ---
I have often regretted my speech, never my silence.
 		-- Publilius Syrus