Thread (53 messages) flat view 53 messages, 3 authors, 2016-06-15

Re: [PATCH 5/8] test-lib.sh: Add a test_set_editor function to safely set $VISUAL

From: Johannes Sixt <hidden>
Date: 2016-06-15 22:44:27

Bryan Donlan schrieb:
+test_set_editor () {
+	# If the editor path contains a quote, just using VISUAL='"path"' isn't
+	# enough.
+	FAKE_EDITOR="$1"
+	export FAKE_EDITOR
+	VISUAL='"$FAKE_EDITOR"'
+	export VISUAL
Clever! It assumes that $VISUAL is always run as sh -c "$VISUAL ...", but
I think this assumption is valid. A hint along these lines in the comment
could turn out helpful.

-- Hannes
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help