Re: [EGIT PATCH 1/4] Change history page table to SWT.VIRTUAL.

"Roger C. Soares" [off-list ref] wrote:

Shawn O. Pearce escreveu:

quoted

Yea, I originally wrote my series around the VIRTUAL flag but on
Win32 it caused ArrayIndexOutOfBoundsExceptions to be thrown from
deep down within the Win32 implementation of the SWT Table widget.

Appears to be something of a known bug, based on the Eclipse issue
tracker, but not much work happening to fix it.

Hum, a VIRTUAL table sounds like a very usefull feature to be badly 
broken on windows, at least there should be some workaround... is it 
easily reproducible?

I tested your patch this evening on Win32.  Its nearly instant.
Seriously.  gitk can't touch it on the same system.  The bug I
was seeing didn't happen.

Originally I wrote the graph table using the ILazyContentProvider
*and* the SWT.VIRTUAL flag.  I didn't realize you had the option to
set only the SWT.VIRTUAL flag.  I think the bug on Win32 is related
to how the ILazyContentProvider gets used by the JFace TableViewer
and less about the SWT.VIRTUAL flag itself.

So anyway, I see no breakage on Mac OS X or Win32 with your patch,
and you said you tested it on Linux, so I'm going to include it.
Thanks for figuring that one out, its a nice performance boost.

quoted

I'll retest this tomorrow on Win32, but I'm pretty certain its
a bad idea on that platform.  What are you running on, Linux?
Maybe we can set this flag everywhere except on Win32

Yep, linux.

Maybe another option to try before leaving windows out is the 
ILazyContentProvider. Have you noticed that while GenerateHistoryJob is 
updating the table you can't use it? Because the input is regenerated 
every time, the table keeps going back to the first row.

Hmm.  I didn't notice that, but at this point its so damn fast for
me that I don't have the reflexes to really try and use the table
before GenerateHistoryJob is complete.  I'll have to add some sleeps
in there to make it slow down its work and see if I can reproduce
what you are describing.

-- 
Shawn.