Re: [PATCH] mktag.c: improve verification of tagger field and tests

On Wed, Mar 26, 2008 at 1:40 AM, Brandon Casey [off-list ref] wrote:

 Well, since I looked at this code and used it in filter-branch, I figured I
 should fix the verification code for the tagger field (even though it's
 probably dieing soon).

 I'm thinking this utility should be fairly strict about the format it accepts.

Why not using git-tag to make tags in filter-branch?

git-mktag was used in git-tag.sh before convert it into
builtin-tag.c, and I didn't know that anyone was using it.

I agree that, if this program exists and it is used,
we should double-check the accepted format and data,
so this patch is a good addition.

However, I think that we should progressively deprecate its
use to avoid mantaining two different ways for creating tags,
so you must have a very good reason to keep using
this tool in a script...

Regards

--
Carlos