Re: [PATCH] gitweb: Remove commit title from comitdiff_plain body
From: Junio C Hamano <hidden>
Date: 2016-06-15 22:44:24
Jakub Narebski [off-list ref] writes:
quoted hunk
Remove commit title (first line of commit message) from the "body" of commitdiff_plain view: it is present there already in format-patch like Subject: header. Signed-off-by: Jakub Narebski <redacted> --- gitweb/gitweb.perl | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index ec73cb1..6e3ab85 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl@@ -5122,8 +5122,11 @@ sub git_commitdiff { print "Subject: " . to_utf8($co{'title'}) . "\n"; print "X-Git-Tag: $tagname\n" if $tagname; - print "X-Git-Url: " . $cgi->self_url() . "\n\n"; + print "X-Git-Url: " . $cgi->self_url() . "\n"; + # remove title, i.e. first line of log + shift @{$co{'comment'}}; + # leading empty lines would separate headers from body foreach my $line (@{$co{'comment'}}) { print to_utf8($line) . "\n"; }
You seem to be assuming messages that follow git convention, but is it a
good assumption here? E.g. is the first element of @[$co{'comment'}]
always known to be non blank? is the second element guaranteed to be
empty?